Skip to content

Stabilise MAS integration #18759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 4, 2025
Merged

Stabilise MAS integration #18759

merged 11 commits into from
Aug 4, 2025

Conversation

@sandhose
Copy link
Member

@sandhose sandhose commented Aug 1, 2025 •
edited
Loading

This can be reviewed commit by commit

There are a few improvements over the experimental support:

  • authorisation of Synapse <-> MAS requests is simplified, with a single shared secret, removing the need for provisioning a client on the MAS side
  • the tests actually spawn a real server, allowing us to test the rust introspection layer
  • we now check that the device advertised in introspection actually exist, making it so that when a user logs out, the tokens are immediately invalidated, even if the cache doesn't expire
  • it doesn't rely on discovery anymore, rather on a static endpoint base. This means users don't have to override the introspection endpoint to avoid internet roundtrips
  • it doesn't depend on authlib anymore, as we simplified a lot the calls done from Synapse to MAS

We still have to update the MAS documentation about the Synapse setup, but that can be done later.

@github-actions github-actions bot deployed to PR Documentation Preview August 1, 2025 10:18 Active
@sandhose sandhose force-pushed the quenting/stable-mas branch from 00684fd to edab4b1 Compare August 1, 2025 16:50
@github-actions github-actions bot deployed to PR Documentation Preview August 1, 2025 16:51 Active
@sandhose sandhose marked this pull request as ready for review August 1, 2025 16:54
@sandhose sandhose requested a review from a team as a code owner August 1, 2025 16:54
@sandhose sandhose force-pushed the quenting/stable-mas branch from edab4b1 to c4c1f7e Compare August 1, 2025 16:56
@github-actions github-actions bot deployed to PR Documentation Preview August 1, 2025 16:57 Active
@sandhose sandhose force-pushed the quenting/stable-mas branch from c4c1f7e to 6806815 Compare August 1, 2025 17:22
@github-actions github-actions bot deployed to PR Documentation Preview August 1, 2025 17:23 Active
@sandhose sandhose marked this pull request as draft August 1, 2025 19:45
@sandhose sandhose force-pushed the quenting/stable-mas branch from 6806815 to 15fc7b0 Compare August 1, 2025 19:47
@github-actions github-actions bot deployed to PR Documentation Preview August 1, 2025 19:49 Active
@sandhose sandhose marked this pull request as ready for review August 1, 2025 20:48
@sandhose sandhose mentioned this pull request Aug 4, 2025
Merged
reivilibre
reivilibre approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the step-by-step commits!

@sandhose sandhose force-pushed the quenting/stable-mas branch from 55e3447 to a23af0f Compare August 4, 2025 12:57
@github-actions github-actions bot deployed to PR Documentation Preview August 4, 2025 12:58 Active
@sandhose sandhose merged commit 7ed5566 into develop Aug 4, 2025
48 checks passed
@sandhose sandhose deleted the quenting/stable-mas branch August 4, 2025 13:48
@sandhose sandhose mentioned this pull request Aug 4, 2025
Merged
@emilylange
Copy link

emilylange commented Aug 10, 2025 •
edited
Loading

With experimental_features.msc3861 being deprecated in favor of matrix_authentication_service (highly appreciated btw) and scheduled for removal in v1.137.0, what's the plan for experimental_features.msc4108_enabled that still asserts for experimental_features.msc3861 being enabled?

synapse/synapse/config/experimental.py

Lines 538 to 544 in 7ed4f65

if (
self.msc4108_enabled or self.msc4108_delegation_endpoint is not None
) and not self.msc3861.enabled:
raise ConfigError(
"MSC4108 requires MSC3861 to be enabled",
("experimental", "msc4108_delegation_endpoint"),
)

Edit: #18808

spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Aug 14, 2025
@spantaleev
Stabilize Matrix Authentication Service integration for Synapse
915d823 
Related to element-hq/synapse#18759

Currently problematic (leading to failures to start for Synapse) because of:
element-hq/synapse#18759 (comment)
spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Aug 14, 2025
@spantaleev
Stabilize Matrix Authentication Service integration for Synapse
a396e32 
Related to element-hq/synapse#18759

Currently problematic (leading to failures to start for Synapse) because of:
element-hq/synapse#18759 (comment)
@spantaleev spantaleev mentioned this pull request Aug 14, 2025
Merged
@sandhose sandhose mentioned this pull request Aug 18, 2025
Merged
MadLittleMods
MadLittleMods reviewed Aug 22, 2025
View reviewed changes
spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Aug 26, 2025
@spantaleev
Stabilize Matrix Authentication Service integration for Synapse
ec8a7a4 
Related to element-hq/synapse#18759

Currently problematic (leading to failures to start for Synapse) because of:
element-hq/synapse#18759 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadLittleMods MadLittleMods MadLittleMods left review comments

@reivilibre reivilibre reivilibre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sandhose @emilylange @MadLittleMods @reivilibre